Open lovasoa opened 3 months ago
I would also like to see support for chunked responses with compression.
I think this may be an API limitation. The actix_web::body::BodyStream type is a stream of actix_web::web::Bytes objects. There is no side channel to express the desire to flush the stream.
With non-compressed streams it works because each Bytes
object is assumed to be a chunk of data that should be flushed eagerly. However with compression it isn't so simple. If a chunk compresses very well it may be desirable to not flush a tiny buffer and send a small packet over the wire. However this is clearly suboptimal in cases like this where there is no next chunk soon to be available.
It would be nice to be able to do both:
However this may require a pretty substantial change to how Body
looks.
For my app only a small number of endpoints rely on streaming chunked responses so I disabled compression on these routes by stripping the Accept-Encoding
header. Ugly, but it lets me get the benefits of compression on most of my routes without throwing away streaming responses.
actix_web::App::new()
.wrap(actix_web::middleware::Compress::default())
.wrap_fn(|mut req, srv| {
if req.path() == "/subscriptions/import" {
req.headers_mut().remove(actix_web::http::header::ACCEPT_ENCODING);
}
actix_web::dev::Service::call(srv, req)
})
.default_service(...)
Initially reported https://github.com/lovasoa/SQLpage/issues/435
When making streaming responses and activating
middleware::Compress
, the compression seems to buffer content indefinitely, without ever flushing the streaming data when it's small enough.Here is an example demonstrating the problem
Expected Behavior
This content appears immediately
immediateley, and then after 5 secondsThis content appears after 5 seconds
Current Behavior
This content appears immediately
andThis content appears after 5 seconds
at the same time.Possible Solution
The compression middleware should flush the writer object after a few milliseconds without new input data, to avoid indefinitely retaining data in memory on the server when it could actually already be rendered on the client.
It's possible to retain data in memory for a few milliseconds to ensure good compression ratios, but actix shouldn't keep streaming data in memory for multiple seconds.
Context
We are trying to integrate easy native loading spinners without javascript in SQLPage
Your Environment