[Bug]Awc client connect websocket ignore the port

[zerodegress]

Expected Behavior

code like below should perform connection to websocket server correctly

let (_, conn) = awc::Client::builder().finish().ws("ws://127.0.0.1:9090/").address(addr).connect().await.map_err(|e| {
        println!("{:?}", e);
    }).unwrap()

Current Behavior

the server responses 400, here's the wireshark captured

Possible Solution

noticed that the upgrade request:

and the code here in awc ws.rs:

according to mdn, i thought maybe the port should be appended to the host, like this: host: 127.0.0.1:9090

Steps to Reproduce (for bugs)

1.install required dependencies(actix_rt, awc) 2.simply run the code above

Context

trying to connect the rosbridge_server(ros kinetic) in websocket protocol.

Your Environment

• Rust Version (I.e, output of rustc -V):1.79.0
• Awc Version: 3.5.0

[zerodegress]

tempory solution(maybe):

let (_, conn) = awc::Client::builder().finish().ws("ws://127.0.0.1:9090/").set_header(actix_http::header::HOST, "127.0.0.1:9090").connect().await.map_err(|e| {
        println!("{:?}", e);
    }).unwrap();

[robjtede]

Seems like http uses a non-standard definition of "host" since the .host() method actually returns the "hostname".

[robjtede]

fixed in 5ad92c0062c3ee972005b9c2b0bbb0c2d5d59fbb

[robjtede]

released in https://github.com/actix/actix-web/releases/tag/awc-v3.5.1