search

actmd / abraham

Trackable application tours for Rails with i18n support
MIT License
124 stars 45 forks source link

Support for Rails 4? #11

Closed fabrouy closed 3 years ago

fabrouy commented 7 years ago

Hello guys,

Is there a reason why there's no support for Rails 4?

Thank you!

jabbett commented 7 years ago

I suppose the only reason is that I've only used Rails 5 ;)

Happy to help make it work if you can point out where the incompatibilities might be.

On Sep 15, 2017, at 2:33 PM, fabrouy notifications@github.com wrote:

Hello guys,

Is there a reason why there's no support for Rails 4?

Thank you!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

fabrouy commented 7 years ago

I will give it a try in Rails 4 and get back.

Velora commented 6 years ago

@fabrouy did you have any issues with this in Rails 4? I am looking to use this in a Rails 4 app as well. Thanks!

willjohnson commented 6 years ago

This was the issue I had when trying to install with Rails 4:

Bundler could not find compatible versions for gem "rails": In snapshot (Gemfile.lock): rails (= 4.2.7.1) In Gemfile: rails (= 4.2.7.1) abraham was resolved to 1.2, which depends on rails (>= 5.0.0.1, ~> 5.0.0)

Velora commented 6 years ago

@willjohnson since abraham is not compatible with rails 4, the gem requires rails 5 or above. That is what that error means.

willjohnson commented 6 years ago

@Velora Understand but the maintainer offered above to help make it work if we can point out where the incompatibilities are :)

scarroll32 commented 3 years ago

Close this issue out?

willjohnson commented 3 years ago

@seanfcarroll I ended up using a JS solution here so no longer an issue for me.

scarroll32 commented 3 years ago

@fabrouy can this issue be closed?

jabbett commented 3 years ago

I just dropped Rails 5.1 testing since I couldn't get it to work reliably in Travis, so I think Rails 4 is beyond me :)