search

actmd / abraham

Trackable application tours for Rails with i18n support
MIT License
124 stars 45 forks source link

Rails 5.1 support #12

Closed dwyerb64 closed 7 years ago

dwyerb64 commented 7 years ago

Hi @jabbett Tried out this gem today and blown away (really impressed). I forked it and changed the rails dependency for it to work with rails 5.1:

See abraham.gemspec line 20.

s.add_dependency 'rails', '~> 5.0', '>= 5.0.0.1'

jabbett commented 7 years ago

I'll try to push a 1.3 release on Monday with this change. Thanks so much for your help!

scarroll32 commented 6 years ago

Hi it doesn't seem to be working...

Bundler could not find compatible versions for gem "rails":
  In snapshot (Gemfile.lock):
    rails (= 5.1.4)

  In Gemfile:
    rails (~> 5.1)

    abraham was resolved to 1.2, which depends on
      rails (>= 5.0.0.1, ~> 5.0.0)
Velora commented 6 years ago

This is a great gem. I wanted to leave a reminder that it looks like this small fix for Rails 5.1 compatibility wasn't released yet.

markhallen commented 6 years ago

This problem is still there:

Bundler could not find compatible versions for gem rails:
In Gemfile:
  rails (~> 5.1.4)

  abraham was resolved to 1.2, which depends on
    rails (>= 5.0.0.1, ~> 5.0.0)
jabbett commented 6 years ago

My sincerest apologies for the delay. I don't have a smooth technique yet for harmonizing the git flow release process with the RubyGems rake release process, so I get cold feet ;)

You'll find the 1.3 release available on RubyGems.

Thank you all for your patience!

markhallen commented 6 years ago

Thanks @jabbett. I integrated this into my project and it is a great gem: thanks a lot.