search

actmd / abraham

Trackable application tours for Rails with i18n support
MIT License
124 stars 45 forks source link

Add placement information to README #45

Closed scarroll32 closed 3 years ago

jabbett commented 3 years ago

Hi @seanfcarroll! Thanks for contributing :)

Since Abraham still uses Shepherd 6, I think the attachment options according to their code are:

const ATTACHMENT = {
  'bottom': 'top center',
  'bottom center': 'top center',
  'bottom left': 'top right',
  'bottom right': 'top left',
  'center': 'middle center',
  'left': 'middle right',
  'middle': 'middle center',
  'middle center': 'middle center',
  'middle left': 'middle right',
  'middle right': 'middle left',
  'right': 'middle left',
  'top': 'bottom center',
  'top center': 'bottom center',
  'top left': 'bottom right',
  'top right': 'bottom left'
};

I'm going to test today to confirm, and I'll add some definitive details to the README.

jabbett commented 3 years ago

Addressed this in #48 -- thanks again for your input!