search

actmd / abraham

Trackable application tours for Rails with i18n support
MIT License
124 stars 45 forks source link

using js-cookie@^3.1 instead of js-cookie@^2.2.0 #74

Open lotfe-obaid opened 1 year ago

lotfe-obaid commented 1 year ago

In our app we use js-cookie@^3.1, and when i tried to down grade to version 2.2, my app doesn't function correctly. so i want to keep using js-cookie@^3.1 i fixed this by: In gems/abraham-2.5.1/app/assets/javascripts/abraham/index.js i changed //= require js-cookie/src/js.cookie to: //= require js-cookie/dist/js.cookie

js-cookie/dist/js.cookie is the default path for version 3.1 i would like to ask , is there a way to do that without modifying the gem?

oclef commented 1 year ago

see my solution to issue

https://github.com/actmd/abraham/issues/69

It should work for you

lotfe-obaid commented 1 year ago

is already working, but i want to keep the gem as it is without modifying anything, i would like to know if there is a way to override the path //= require js-cookie/src/js.cookie to: //= require js-cookie/dist/js.cookie from outside the gem

update: i saw this reply but i am looking for a better solution https://github.com/actmd/abraham/issues/31#issuecomment-920628152

lotfe-obaid commented 1 year ago

@jabbett it would be appreciated if you could upgrade js-cookies to any newer version with the newer path js-cookie/dist/js.cookie this is our major compatibility issue which forces us to modify on the gem. i have created a pull request https://github.com/actmd/abraham/pull/76