search

actris-cloudnet / cloudnetpy

Python package for Cloudnet data processing
MIT License
36 stars 27 forks source link

added ice effective radius product from Griesche et al. 2020 #51

Closed KarlJohnsonnn closed 2 years ago

KarlJohnsonnn commented 2 years ago

Griesche et al. 2020 ice effective radius calculation

KarlJohnsonnn commented 2 years ago

Hi,

I need help, somehow the checks were not successful, see error

I used the same notation as for iwc.py comments, a dict with key and tuple of comments. Not sure why it fails here but not in der or other products.

tukiains commented 2 years ago

I believe you need to at least git rebase master and to fix merge conflicts first.

KarlJohnsonnn commented 2 years ago

I did git rebase master and followed along. The merge conflicts were resolved and changes are pushed but still checks are not successful?

tukiains commented 2 years ago

The errors come from the cloudnetpy-qc package. We are fixing these right now.. Let's see if the tests pass soon.

KarlJohnsonnn commented 2 years ago

@siiptuo Thanks for spotting the typos! It seems to work now.

tukiains commented 2 years ago

Great! We well take a closer look at it now.

tukiains commented 2 years ago

Thanks again @KarlJohnsonnn! Good work! :+1: