search

actris-cloudnet / cloudnetpy

Python package for Cloudnet data processing
MIT License
34 stars 26 forks source link

Update mira.py #84

Closed spirrobe closed 1 year ago

spirrobe commented 1 year ago

Summary: Changes to mira2nc to support znc input (and STSR) for the whole of cloudnet

Added 2 helper functions to mira2nc which handle the specific keymap for the filetype (mmclx or znc) and removal of DropSize which according to the MetekManual has the dimensions range and Doppler (but no time as it is assumed to change little). This creates a concat conlfict and thus requires removal. Minor error catching for empty filelist as the recent change to be able to pass in a list requires a filetype and may lead to a potentially empty filelist.

Closes #83

siiptuo commented 1 year ago

Thanks for the contribution! Please follow these instructions to make sure that your changes pass the automated tests.

spirrobe commented 1 year ago

Seems to pass most tests (2x test_advance_methods.py, 2x in test_tools.py which should be unrelated to changes in mira.py ) / precommit is working now, voodoonet was missing as it is listed as extra in the pyprojects.toml but there is no check for a potential ImportError in categorize.classify Looking at the tests/unit/test_mira.py, esp. test_variable_names would need some adjustment for the ZNC files as well.

siiptuo commented 1 year ago

Thanks for the clean implementation!

voodoonet was missing as it is listed as extra in the pyprojects.toml but there is no check for a potential ImportError in categorize.classify Looking at the tests/unit/test_mira.py, esp. test_variable_names would need some adjustment for the ZNC files as well.

We'll look into it.