Open rahmans1 opened 2 years ago
Suggestions provided by @wdconinc. Just wanted to make sure that nobody else is actively working or planning to work on it. If not, I will be doing it in this branch.
ping @asalzburger
Incidental questions brought up in the ATHENA-ACTS meeting.
@noraemi do you want to chime in?
I didn't extend the RadialBounds to include the bevel as the bevel would be a property of the cylinder and otherwise its just a tilted disc? But if necessary I could add it
Intuitively speaking, it doesn't make sense for radial bounds to include a bevel. But we can either force it in for consistency. Or an alternative may be to assign a warning to the user that TGeoCtub cannot be used for discs.
This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.
Adding an update to this discussion https://indico.bnl.gov/event/15458/contributions/62426/attachments/40571/67801/ACTS%20integration%20for%20B0%20tracker.pdf
This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.
Proposed labels: Improvement, Needs Discussion
Proposed next steps on cut tube support that touch the Acts code base:
1) Extend TGeoTubeConversionTests.cpp with a TGeoCtub (like done here for TGeoTubeSeg), this test will fail until support below is added,
The test above should now succeed.
2) extend Acts::DD4hepLayerBuilder::endcapLayers (like done here for TGeoTubeSeg) and Acts::DD4hepLayerBuilder::centralLayers (like done here for TGeoTubeSeg) to support TGeoCtub.
3) Are there any DD4hep unit tests that should be updated to test?