acts-project / acts

Experiment-independent toolkit for (charged) particle track reconstruction in (high energy) physics experiments implemented in modern C++
https://acts.readthedocs.io
Mozilla Public License 2.0
102 stars 165 forks source link

ci: kodiak does not update branches on automerge #3234

Closed AJPfleger closed 3 months ago

AJPfleger commented 3 months ago

Issue

When the automerge-label is set, the PR needs to be updated manually, to merge it. Otherwise it will get stuck.

Example Error

copied from https://github.com/acts-project/acts/pull/3208/checks?check_run_id=25575393299

⚠️ problem contacting GitHub API with method 'pull_request/update_branch'

Errors encountered when contacting GitHub API.

API call 'pull_request/update_branch' failed with HTTP status '403' and response: 'b'{"message":"refusing to allow a GitHub App to create or update workflow .github/workflows/analysis.yml without workflows permission","documentation_url":"https://docs.github.com/rest/pulls/pulls#update-a-pull-request-branch"}\''

Hints to solve this issue

Maybe a token expired.

paulgessinger commented 3 months ago

I think this is an issue in branches and merges which would touch CI files. I believe this has never worked, and the PRs just need to be updated manually until the changes are through the pipeline of updates.

I think I tried to follow this up with the Kodiak developer and there was no way to fix this.

paulgessinger commented 3 months ago

See https://github.com/chdsbd/kodiak/issues/853

AJPfleger commented 3 months ago

Seems like we cannot do enough about this, since it is intended to work like this. Since we just need to update manually, when there was a CI change before, it is not a huge issue. Close it for now and keep it in the archive.