Open stephenswat opened 2 months ago
For the record, my current workaround for local builds is this:
cmake -B build -S . --preset github-ci -DCMAKE_CXX_COMPILER_LAUNCHER=""
@andiwand
Also, fyi, you can add a CMakeUserPresets.json
with custom presets that can extend the original ones.
Sounds good to me. I put it there because we (or maybe I) use it everywhere. In the CI and local (since I have multiple ACTS build folder).
I didn't know that there is multiple inheritance which felt like a limitations to me. If you have a nice separation in mind I am happy to review!
I think the CI mode also enables -Werror
, which you might not want for local development.
This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.
I've been trying to use the
github-ci
preset as a sort of "build everything, so if it works locally it will most likely pass the CI" build. However, I have noticed that this sets ccache as the compiler launcher. Makes sense, of course, for a CI preset. However, it appears that ccache is required in thecommon
preset, from which all others inherit.In my mind, it would be useful to have an "everything" preset for local builds, which does not require ccache. Given the multiple inheritance that CMake presets allow, I'd suggest we could have a
ccache
preset which setsccache
, and thencommon
could have the launcher flag removed. We could then also have some kind ofeverything
flag which would just build everything, like theACTS_BUILD_EVERYTHING
flag used to do.Looking to see if anyone has any opinions on this so we can come to a nice compromise that everyone agrees with.