acts-project / acts

Experiment-independent toolkit for (charged) particle track reconstruction in (high energy) physics experiments implemented in modern C++
https://acts.readthedocs.io
Mozilla Public License 2.0
106 stars 172 forks source link

test: some bounding box test cases fail on macOS ci #3847

Open AJPfleger opened 2 weeks ago

AJPfleger commented 2 weeks ago

Many cases were disabled in Tests/UnitTests/Core/Utilities/BoundingBoxTest.cpp because of fails with double precision. After rechecking all tests in

The disabled tests are:

    // upper bound is exclusive - temporarily removed, fails macOS ci
    // ray = {{-2, 1}, {1, 0}};
    // BOOST_CHECK(!bb.intersect(ray));

    // upper bound is exclusive - temporarily removed, fails macOS ci
    // ray = {{2, 1}, {-1, 0}};
    // BOOST_CHECK(!bb.intersect(ray));

    // right on slab - temporarily removed, fails macOS ci
    // ray3 = {{0, 1, -2}, {0, 0, 1}};
    // BOOST_CHECK(!bb3.intersect(ray3));

The reason is not clear yet and should be investigated.