search

acts-project / algebra-plugins

Mozilla Public License 2.0
3 stars 10 forks source link

CMake Updates, main branch (2023.03.29.) #101

Closed krasznaa closed 1 year ago

krasznaa commented 1 year ago

Introduced ALGEBRA_PLUGINS_FAIL_ON_WARNINGS. Instead of only using -Werror (and similar flags) for debug builds, it is now possible to add -Werror to the build in any build mode. This is following the same sort of setup as in https://github.com/acts-project/vecmem/pull/210 and https://github.com/acts-project/traccc/pull/334.

Updated the CI to set ALGEBRA_PLUGINS_FAIL_ON_WARNINGS to TRUE in all tests.

Note that I was intending to add -Wconversion as a warning as well, but that triggered on a gazillion of floating point literals in the unit tests. (Complaining that double precision literals are converted into single precision values.) That just not seemed reasonable to do. As the readability of the unit tests would've been seriously hurt.

Also note that I realized, while updating the builds.yml configuration, that I forgot to add -DALGEBRA_PLUGINS_BUILD_BENCHMARKS=TRUE for the "native builds" in #99. So I'm sneaking in that fix here...

niermann999 commented 1 year ago

I just used float literals in detray. Except for one test in the material, the testing accuracy seemed fine