search

acts-project / algebra-plugins

Mozilla Public License 2.0
3 stars 10 forks source link

Silence Eigen Warnings From CUDA on Windows, main branch (2023.10.09.) #110

Closed krasznaa closed 11 months ago

krasznaa commented 11 months ago

Turned off specific CUDA warnings for the Eigen headers.

This is only needed with MSVC, since "system include directories" as a concept doesn't quite work with that compiler. 😦 (On Linux we are shielded from these warnings by: https://github.com/acts-project/algebra-plugins/blob/main/extern/eigen3/CMakeLists.txt#L39-L44) So we need to explicitly turn off the checking for some warnings in the code like this.

@niermann999, you mentioned in https://github.com/acts-project/algebra-plugins/pull/95#issuecomment-1752741760 that you observe warnings yourself as well. Could you elaborate? Since I only know at this point why there would be warnings on Windows. But on Linux there should not have been any to begin with. 🤔

P.S. Note that the master branch of Eigen doesn't produce any warnings/errors with our code. But it's not clear when we should expect new releases out of those guys. 😦 See:

niermann999 commented 11 months ago

I saw warnings in host code about uninitialized parameters that don't appear in the detray CI, but let me check again

krasznaa commented 11 months ago

Looks good to me.

BTW, how do you compile and test MSVC compiler? Do you have any Windows image in your local linux machine or is that even possible

Windows image... I use Windows on my laptop for this. :wink:

image

beomki-yeo commented 11 months ago

OK. CI failures with MSVC was a horror to me when I didn't have a Windows license :smiley: