search

acts-project / algebra-plugins

Mozilla Public License 2.0
3 stars 10 forks source link

Uniform way of deciding whether to use system libs or not #82

Closed wermos closed 1 year ago

wermos commented 1 year ago

For Vecmem, CMake sets the default value of ALGEBRA_PLUGINS_USE_SYSTEM_VECMEM to the value of ALGEBRA_PLUGINS_USE_SYSTEM_LIBS: https://github.com/acts-project/algebra-plugins/blob/73c29e9d53ea91ee53af205a8db64aacbdc21ceb/CMakeLists.txt#L67-L69

However, for the setup of the math backends, we have https://github.com/acts-project/algebra-plugins/blob/73c29e9d53ea91ee53af205a8db64aacbdc21ceb/CMakeLists.txt#L111-L113

https://github.com/acts-project/algebra-plugins/blob/73c29e9d53ea91ee53af205a8db64aacbdc21ceb/CMakeLists.txt#L125-L127

https://github.com/acts-project/algebra-plugins/blob/73c29e9d53ea91ee53af205a8db64aacbdc21ceb/CMakeLists.txt#L147-L149

This is unexpected and leads to unnecessary surprises when building the library from scratch on a new system. I think we should use ALGEBRA_PLUGINS_USE_SYSTEM_LIBS across the board.

wermos commented 1 year ago

I'm closing this issue as #84 addressed it.