search

acts-project / algebra-plugins

Mozilla Public License 2.0
3 stars 10 forks source link

Benchmarks Fix, main branch (2023.03.29.) #99

Closed krasznaa closed 1 year ago

krasznaa commented 1 year ago

Removed the reference to the non-existent benchmarks/ directory. This was introduced in #69, which I just really don't see the point in now that I look back. :frowning: (One would only add Google Benchmark in the PR in which it is first needed. And touching all those files without a need is just pretty bad... :frowning:)

At the same time enabled the "build of benchmarks" in the CI. In case we ever add some to the project...

beomki-yeo commented 1 year ago

I think it is best to be reviewed by @niermann999

krasznaa commented 1 year ago

To make it clear: If you currently use -DALGEBRA_PLUGINS_BUILD_BENCHMARKS=TRUE in your build, your configuration fails. (As the configuration tries to open a directory that is just not there.)

This is how I discovered this issue. By trying to make sure that all parts of the code would be compiled for another development that I'm working on at the moment.

niermann999 commented 1 year ago

Benchmarks are added in #95 and the benchmarks directory is filled there. I am Ok with fixing this in the meantime

krasznaa commented 1 year ago

That does paint it in a slightly different light, but let's just add back the add_subdirectory(...) call in #95 then. Once there is actually a subdirectory there. :wink: