acts-project / detray

Test library for detector surface intersection
Mozilla Public License 2.0
10 stars 18 forks source link

ref: Harmonize cmake warnings with ACTS and switch false warnings off #813

Closed niermann999 closed 2 weeks ago

niermann999 commented 2 weeks ago

Add missing warnings to detray so that they can be caught before integration into ACTS. One null-dereference warning that happens in a boost header gets ignored using pragmas

niermann999 commented 2 weeks ago

Does the compiler recognize the asserts actually?

In order to get rid of the warnings, no, because the null-dereference warnings only really take effect in a Release build, if I am not mistaken. The asserts just reassured me, that there are indeed no nullptrs ever in circulation anywhere

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarCloud