search

acts-project / detray

Test library for detector surface intersection
Mozilla Public License 2.0
10 stars 18 forks source link

Ignore some bfield gradient terms in RKN Jacobian calculation #815

Closed beomki-yeo closed 1 week ago

beomki-yeo commented 2 weeks ago

This PR makes dkn/dqop and dkn/dt neglect the mangetic field gradient terms with dB/dr, they are negligible compared to other terms.

It seems the plots from jacobian_validation do not make any noticeable difference.

stephenswat commented 2 weeks ago

@beomki-yeo you seem to be committing as @actions-user; is that intentional? Did you change your git config?

beomki-yeo commented 2 weeks ago

Yeah I think I was set to the wrong name. I don't know how it happened though

beomki-yeo commented 2 weeks ago

I don't know what sonarcloud is about but it seems failing in this PR. someone can re-run it?

niermann999 commented 1 week ago

I don't know what sonarcloud is about but it seems failing in this PR. someone can re-run it?

It is static analyzer for code quality, but the reporting seems to have gotten stuck with this PR. Looking at the latest scan on their website, I think it actually passed. The Quality Gate is not a prerequisite for passing the CI atm, so we can go ahead and merge this

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud