search

acts-project / detray

Test library for detector surface intersection
Mozilla Public License 2.0
10 stars 18 forks source link

Add back the full jacobian to the base stepper #838

Closed beomki-yeo closed 5 days ago

beomki-yeo commented 5 days ago

I found that full jacobian is required in smoother in Kalman Fitter :skull_and_crossbones: Roll back #832

niermann999 commented 5 days ago

and it is impossible to call get_full_jacobian?

beomki-yeo commented 5 days ago

The kalman actor used to take the stepping._full_jacobian which was calculated in the parameter transporter. If we use get_full_jacobian in kalman actor, we will repeat the same calculation.

Fortunately, #832 didn't even noticeably increased the benchmark performance so hopefully we won't lose any performance

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud