acts-project / traccc

Demonstrator tracking chain on accelerators
Mozilla Public License 2.0
29 stars 50 forks source link

Use surface link for module projection #729

Closed beomki-yeo closed 1 month ago

beomki-yeo commented 1 month ago

I think module links do not have to be used after clusterization. This also helps the currect refactoring of #692

beomki-yeo commented 1 month ago

Actually module_link can be dropped from the measurement as it is not used anywhere but some tests - this will be followed up later

beomki-yeo commented 1 month ago

@stephenswat Any thought?

krasznaa commented 1 month ago

I believe this is fine. But this PR by itself is really meaningless in my mind. For this to be meaningful, you should:

Could you add the first 2 points to this PR as well?

beomki-yeo commented 1 month ago

OK I removed the module link of measurements

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
26.7% Duplication on New Code

See analysis details on SonarCloud

beomki-yeo commented 1 month ago

@krasznaa Could you review the PR?