Wrap the phi of track parameters in the range of [-pi,pi]

[beomki-yeo]

This is for constraining the values of phi from Kalman updater and smoother to be within [-pi,pi]. If we don't do this, very occasionally, the while loop of wrap_to_pi of is_same_angle can take very long time.

[stephenswat]

Wouldn't it be better to use fmod ( https://en.cppreference.com/w/c/numeric/math/fmod) in the method that has to wrap the phi values?

On Mon, 14 Oct 2024, 14:38 sonarcloud[bot], @.***> wrote:

[image: Quality Gate Passed] https://sonarcloud.io/dashboard?id=acts-project_traccc&pullRequest=736 Quality Gate passed

Issues

https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67 0 New issues https://sonarcloud.io/project/issues?id=acts-project_traccc&pullRequest=736&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true

https://camo.githubusercontent.com/86e5c40907bf9e8933fe6bcf185f7076622a76a3bef4b6d2b5fd583959409aef/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f61636365707465642d313670782e706e67 0 Accepted issues https://sonarcloud.io/project/issues?id=acts-project_traccc&pullRequest=736&issueStatuses=ACCEPTED

Measures

https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67 0 Security Hotspots https://sonarcloud.io/project/security_hotspots?id=acts-project_traccc&pullRequest=736&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true

https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67 0.0% Coverage on New Code https://sonarcloud.io/component_measures?id=acts-project_traccc&pullRequest=736&metric=new_coverage&view=list

https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67 0.0% Duplication on New Code https://sonarcloud.io/component_measures?id=acts-project_traccc&pullRequest=736&metric=new_duplicated_lines_density&view=list

See analysis details on SonarCloud https://sonarcloud.io/dashboard?id=acts-project_traccc&pullRequest=736

— Reply to this email directly, view it on GitHub https://github.com/acts-project/traccc/pull/736#issuecomment-2411118679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI4T7AQ7KH4UNPRRUWR5TLZ3O3NDAVCNFSM6AAAAABP27FL7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJRGEYTQNRXHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[beomki-yeo]

I think this PR is using fmod

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud