acts-project / traccc

Demonstrator tracking chain on accelerators
Mozilla Public License 2.0
29 stars 50 forks source link

Double matching condition for track finding effieicny #745

Closed beomki-yeo closed 1 month ago

beomki-yeo commented 1 month ago

Based on #692

Double matching condition:

  1. The number of measurements from the major particle is larger than a half of the number of the measurements of the found track
  2. The number of measurements from the major particle is larger than a half of the number of measurements produced by the particle

We have been only using the first condition. This PR adds the second one.

Relevant ACTS code can be found here: https://github.com/acts-project/acts/blob/f935e2512cc72577eb9aa9934a6f7b52f4c0dd53/Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackTruthMatcher.cpp#L105

As expected, the efficiency drops but not so much

Before

After

beomki-yeo commented 1 month ago

This is the final PR before creating the tag...

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

beomki-yeo commented 1 month ago

The plot gets more sense now...

single muon events

Before with the bug in division image

After fixing the bug image

beomki-yeo commented 1 month ago

The recovery at eta~0 makes sense: As the track is orthogonal to the module, the cluster size (# number of cells) are usually small so the hit count sum frequently gets smaller than the measurements size which makes the value of division zero