search

acts-project / traccc

Demonstrator tracking chain on accelerators
Mozilla Public License 2.0
29 stars 50 forks source link

macOS Fixes, main branch (2024.10.26.) #755

Closed krasznaa closed 1 month ago

krasznaa commented 1 month ago

Triggered by the report from @CrossR and Fabrice, these are things that I needed to fix to make the project (without any GPU support of course...) build on macOS 15.0.1 with Xcode 16.0.

The biggest one being that traccc_benchmarks_common was set up very incorrectly so far. Yet, the archival application (ar) on Linux did not complain about this for some reason. Apparently on Linux it's okay to create a static library with absolutely no content. But on macOS it clearly isn't. 🤔

The rest are some conversion issues and a missing include.

paulgessinger commented 1 month ago

The sonar issue is just complaining about pseudo random numbers as usual.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

krasznaa commented 1 month ago

Decided to add a CI test on macOS already as part of this PR. Tried to make it as simple as possible.

@paulgessinger, what do you think?