Skip some SoA tests on devices with no FP64 support.
The device tests with vecmem::testing::jagged_soa_container require the device to be able to execute FP64 operations. (Since the SoA container has a jagged vector of doubles.) Which is not the case for absolutely every SYCL device that we test. So on those these tests should just be skipped.
I considered removing the FP64 instructions from the test. But in the end decided that doing some tests with FP64 values was still worth it. To test for some possible alignment issues in the SoA code. So just skipping these tests all together on devices with no FP64 support seemed better than making the tests less thorough on all devices.
Unfortunately implementing this was a bit of a hassle. :frowning: As it turns out, one can only use GTEST_SKIP() in the main test body. You cannot just use that macro inside of a function that gets called as part of the test. :frowning: So I decided to add a simple bool return value to all language-specific functions, and let the main test body call GTEST_SKIP() based on those return values. :thinking:
Skip some SoA tests on devices with no FP64 support.
The device tests with
vecmem::testing::jagged_soa_containerrequire the device to be able to execute FP64 operations. (Since the SoA container has a jagged vector of doubles.) Which is not the case for absolutely every SYCL device that we test. So on those these tests should just be skipped.I considered removing the FP64 instructions from the test. But in the end decided that doing some tests with FP64 values was still worth it. To test for some possible alignment issues in the SoA code. So just skipping these tests all together on devices with no FP64 support seemed better than making the tests less thorough on all devices.
Unfortunately implementing this was a bit of a hassle. :frowning: As it turns out, one can only use
GTEST_SKIP()in the main test body. You cannot just use that macro inside of a function that gets called as part of the test. :frowning: So I decided to add a simpleboolreturn value to all language-specific functions, and let the main test body callGTEST_SKIP()based on those return values. :thinking: