acts-project / vecmem

Vectorised data model base and helper classes.
https://acts-project.github.io/vecmem/
Mozilla Public License 2.0
19 stars 13 forks source link

Copy (Test) Improvements, main branch (2024.02.29.) #270

Closed krasznaa closed 6 months ago

krasznaa commented 6 months ago

Managed to hit "Enter" with my pinkie a bit too early... :frowning:

This is a follow-up from #268.

With all of this in place, all copy related issues are gone from my tests now... :crossed_fingers:

krasznaa commented 6 months ago

The "SEH exceptions" on Windows turned out to come from this:

https://forums.developer.nvidia.com/t/accessing-managed-memory-during-asynchronous-copies/

So I just disabled some tests on Windows...

krasznaa commented 6 months ago

With the conclusions coming out of

https://forums.developer.nvidia.com/t/accessing-managed-memory-during-asynchronous-copies/

I considered for a bit if the vecmem::copy code could potentially detect when it can and can't do certain copy operations asynchronously. But in the end, that would be super difficult to do. (The "copy code" should not know what type of memory resources it is dealing with.) So let's just stay with disabling some of the tests on Windows, and then remembering this limitation in case some user stumbles upon it in the future.