coderabbitai[bot]
commented
2 months ago Walkthrough
This pull request introduces the RevolutRevolt21 module to the application, enhancing the handling of bank transactions specifically for Revolut. It includes a new method for normalizing transactions related to Bizum payments while retaining fallback integration logic. Additionally, the type definition for the Transaction type is updated by renaming a property for clarity. Unit tests for the new module are also added to ensure proper functionality.
Changes
| File | Change Summary |
|---|---|
src/app-gocardless/bank-factory.js |
Updated imports and modified the banks array to include NbgEthngraaxxx, RevolutRevolt21, and SandboxfinanceSfin0000, while removing duplicates and expanding the BANKS_WITH_LIMITED_HISTORY array. |
src/app-gocardless/banks/revolut_revolt21.js |
Introduced a new module for handling Revolut transactions, including a normalizeTransaction method for Bizum payments. |
src/app-gocardless/banks/tests/revolut_revolt21.spec.js |
Added unit tests for the normalizeTransaction method, validating its functionality for Bizum expense and income transfers. |
src/app-gocardless/gocardless-node.types.ts |
Renamed property proprietaryBank to proprietaryBankTransactionCode in the Transaction type definition. |
Possibly related PRs
-
448: The addition of the
RevolutRevolt21module in the main PR is similar to the addition of theNbgEthngraaxxxmodule in PR #448, as both involve expanding thebanksarray insrc/app-gocardless/bank-factory.jsto include new bank entities.
Suggested labels
:sparkles: Merged
Suggested reviewers
- MatissJanis
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
hostyn
In Spain, we have a protocol called Bizum that allows instant transactions via phone number. Revolut recently added support for these transactions, but the information displayed for them was a bit messy.
I fixed this by adding a Revolut integration, only modifying the Bizum transactions, as all other transactions were displayed correctly. I also added tests for these transactions.
Additionally, I fixed the transaction type, which was using
proprietaryBankinstead ofproprietaryBankTransactionCode. As you can see here, this seems like an error. I didn't find any reference toproprietaryBankin the code but did find some forproprietaryBankTransactionCode, so this definitely looks like a mistake.I found this error because I initially intended to use
proprietaryBankTransactionCode, but in the end, it wasn't necessary.