Open UnderKoen opened 4 days ago
The changes include the addition of new test cases for the sortByBookingDateOrValueDate
function to enhance its coverage, specifically addressing sorting by valueDate
and handling multiple date fields. A new function compareDates
is introduced in the utils.js
file to facilitate date comparisons, and the existing sorting function is modified to utilize this new comparison mechanism. The method signature of sortByBookingDateOrValueDate
has been updated, and the compareDates
method has been added.
Files | Change Summary |
---|---|
src/app-gocardless/tests/utils.spec.js | Added new test cases for sortByBookingDateOrValueDate to cover sorting by valueDate and multiple fields. Retained existing tests for bookingDate . |
src/app-gocardless/utils.js | Introduced compareDates function for date comparisons and modified sortByBookingDateOrValueDate to use new comparison functions. Updated method signature. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
I noticed that the transaction that were synced were really out of order of how they happend. This should fix this by also sorting on time