Closed MikesGlitch closed 3 weeks ago
The changes in the pull request focus on the initialization process of the application following database migrations. The previous implementation involved directly invoking the run
function from app.js
immediately after the successful completion of migrations. The updated approach modifies this by introducing a dynamic import of app.js
within a .then()
callback, which ensures that the application is only imported and executed once the migrations have been fully resolved. This adjustment emphasizes the dependency of the application on the successful completion of migrations before it can start. Furthermore, the error handling mechanism remains unchanged, continuing to log any errors that occur during the migration process and terminating the application with an exit code of 1 if necessary. Additionally, the method signature for the run()
function has been updated to reflect this new import structure.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This PR introduced a dependency in the app to have the user-files and server-files folders available.
That's fine, but we need to ensure those folders exist before importing the app. If we don't the files-service will fail.
Related support thread: https://discord.com/channels/937901803608096828/1299430821509206160