actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
15.58k stars 1.21k forks source link

[Feature] Allow child transactions in a split transaction to have different payees #1567

Closed joel-jeremy closed 1 year ago

joel-jeremy commented 1 year ago

Verified feature request does not already exist?

đź’»

Pitch: what problem are you trying to solve?

When doing transfers/bill payments in fintech apps, there's usually fees associated with every transaction. It would be great if we could model these fees through split transactions. Right now, users will need to create a separate transaction for fees which can make it hard to track which parent transaction that fee is for.

Describe your ideal solution to this problem

Allow child transactions in a split transaction to have different payees

Teaching and learning

No response

github-actions[bot] commented 1 year ago

:sparkles: Thanks for sharing your idea! :sparkles:

This repository uses lodash style issue management for enhancements. That means enhancement issues are automatically closed. This doesn’t mean we don’t accept feature requests, though! We will consider implementing ones that receive many upvotes, and we welcome contributions for any feature requests marked as needing votes (just post a comment first so we can help you make a successful contribution).

The enhancement backlog can be found here: https://github.com/actualbudget/actual/issues?q=label%3A%22needs+votes%22+sort%3Areactions-%2B1-desc+

Don’t forget to upvote the top comment with 👍!

kyrias commented 1 year ago

Child transactions can already have different payees.

joel-jeremy commented 1 year ago

That is true for transfer payees but for regular payees, they do not show up on the payee selection.

kyrias commented 1 year ago

The UI is a bit wonky here, but if you click the yellow "Make Transfer" button you can select among all of them. For some reason showing only the transfer payees is the default on child transactions, though I don't understand why.

@MatissJanis Does the current default behavior make sense to you? Otherwise I think we should change it.

joel-jeremy commented 1 year ago

I think we should show regular payees too in the payee selection for child transactions. This is useful for entering transaction fees.

kyrias commented 1 year ago

My point is that we do, we just don't do it by default and I think we should change this default.

joel-jeremy commented 1 year ago

Sorry, yeah - I meant show them by default. I agree.

joel-jeremy commented 1 year ago

There also seems to be a bug with the amounts. I split the transaction between an off-budget account and a payee and the whole transaction amount (100) was deposited to the off-budget account instead of the the child amount (50):

image image

kyrias commented 1 year ago

Ah, that's because the payee of the parent transaction is the transfer payee. The simple work-around would be to have the non-transfer payee as the payee of the parent transaction.

I have a feeling that this will be involved to fix, but please do file a bug issue about it.

joel-jeremy commented 1 year ago

Thank you! The workaround works. I have filed a separate bug report for this: https://github.com/actualbudget/actual/issues/1574