search

actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
13.96k stars 1.11k forks source link

[WIP] Category Group selectable in Category Autocomplete to filter #2874

Closed lelemm closed 3 months ago

lelemm commented 3 months ago

fix #2873

netlify[bot] commented 3 months ago

Deploy Preview for actualbudget ready!

Name Link
Latest commit 286cf35eeb06d1123266edbdbcf40e9131f6f4a2
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/666aebf4f6cc8b0008849298
Deploy Preview https://deploy-preview-2874.demo.actualbudget.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 months ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.75 MB → 4.75 MB (+3.68 kB) +0.08%
Changeset File | Δ | Size ---- | - | ---- `src/components/autocomplete/ItemHeader.tsx` | 📈 +192 B (+38.79%) | 495 B → 687 B `src/components/autocomplete/CategoryAutocomplete.tsx` | 📈 +3.36 kB (+36.49%) | 9.21 kB → 12.58 kB `src/components/autocomplete/Autocomplete.tsx` | 📈 +135 B (+0.81%) | 16.27 kB → 16.4 kB
View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.01 MB → 3.02 MB (+4.32 kB) | +0.14% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/wide.js | 263.58 kB → 262.94 kB (-656 B) | -0.24% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/usePreviewTransactions.js | 790 B | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/AppliedFilters.js | 21.23 kB | 0% static/js/narrow.js | 75.66 kB | 0% static/js/ReportRouter.js | 1.23 MB | 0%
github-actions[bot] commented 3 months ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.13 MB | 0%
Crazypkr1099 commented 3 months ago

Hey, just checked it out. Your missing the category when searching for the subcategory.

If I have multiple subcategories with the same name, there's nothing to show what category it is...

Screenshot_20240612_155728_Chrome

lelemm commented 3 months ago

Hey, just checked it out. Your missing the category when searching for the subcategory.

If I have multiple subcategories with the same name, there's nothing to show what category it is...

Screenshot_20240612_155728_Chrome

Thanks for the feedback, I didn't noticed it

Crazypkr1099 commented 3 months ago

Hey, just checked it out. Your missing the category when searching for the subcategory. If I have multiple subcategories with the same name, there's nothing to show what category it is... Screenshot_20240612_155728_Chrome

Thanks for the feedback, I didn't noticed it

Also just one more personal comment... I don't like how subcategories are hidden as well. I get you made the category clickable but when im searching category its nice to see all the subcategories. I think the best way to have this implemented is like the discussion in actual discord dev chat: show subcategories first, and then afterwards show matching categories.

Personal opinion, but I feel like it would be a bit of a pain clicking on the category and then selecting the sub cat.

lelemm commented 3 months ago

I'll change according your suggestions. After playing around a little more I don't like the behavior atm

lelemm commented 3 months ago

Pushed the changes

https://github.com/actualbudget/actual/assets/15043428/35aeac27-d16d-4002-b942-a77f5b88726e

lelemm commented 3 months ago

@Crazypkr1099 check what you think about this new version. The groups are selectable after you start a filter, before that not. I reverted the change where the categories were filtered without the group name too.

Crazypkr1099 commented 3 months ago

@Crazypkr1099 check what you think about this new version. The groups are selectable after you start a filter, before that not. I reverted the change where the categories were filtered without the group name too.

I appreciate all the work you've done, but I very much dislike having to click the group to see the sub category.

I think it's best if it's such shown underneath, like my #2861 PR.

lelemm commented 3 months ago

I must pay more attention. Didn't saw your PR about the same feature. this was driving me crazy lately so I just coded lol. I will close my PR cuz there is no point on this