actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
13.96k stars 1.11k forks source link

Custom Reports: fix card menus regression #2878

Closed carkom closed 3 months ago

carkom commented 3 months ago

A regression was introduced in #2778 that broke the menus for the individual custom report cards. Here is the fix.

netlify[bot] commented 3 months ago

Deploy Preview for actualbudget ready!

Name Link
Latest commit fadf510dd1d618244243fd51a60086cff5abb869
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/666ab1c22b0b9a0008d75730
Deploy Preview https://deploy-preview-2878.demo.actualbudget.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 months ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.75 MB → 4.75 MB (+263 B) +0.01%
Changeset File | Δ | Size ---- | - | ---- `src/components/reports/reports/ListCardsPopover.tsx` | 🆕 +2.11 kB | 0 B → 2.11 kB `src/components/reports/reports/ListCardsMenu.tsx` | 🆕 +344 B | 0 B → 344 B `src/components/reports/reports/CustomReportListCards.tsx` | 📉 -2.18 kB (-24.16%) | 9.04 kB → 6.86 kB
View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.23 MB → 1.23 MB (+263 B) | +0.02% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/usePreviewTransactions.js | 790 B | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/AppliedFilters.js | 21.23 kB | 0% static/js/narrow.js | 75.66 kB | 0% static/js/wide.js | 263.58 kB | 0% static/js/index.js | 3.01 MB | 0%
github-actions[bot] commented 3 months ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.13 MB | 0%
MatissJanis commented 3 months ago

Thanks!