[Bug]: transactions table - select all not selecting schedules

[MatissJanis]

Verified issue does not already exist?

• [X] I have searched and found no existing issue
• [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Reproduction:

1. open transactions table (that has schedules too)
2. click the "select all" box
3. notice only the transactions get selected - schedules are not selected

https://github.com/actualbudget/actual/assets/886567/8141fc53-8f85-4a46-9b8b-e1385ff46dbf

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

[MatissJanis]

Looks like it doesn't select split-transaction parent transactions either.

[youngcw]

This feels like the correct behavior to me. Schedules are different than regular transactions and if the split parent is included in the selection the amount calculations get messed up.

[MatissJanis]

Interesting perspective. From a usability POV I would expect a "select all" checkbox in the header to do what most other products do - to select all the entries within the table. Is there a good argument for why we should treat schedules differently?

if the split parent is included in the selection the amount calculations get messed up

IMO this is an unrelated problem. Even if you manually select the parent + children transactions - the calculations get messed up. It definitely should be addressed. But it's not really related to select-all functionality.

[dangrous]

To be honest, I would lean towards @youngcw's perspective that - for me - this is the ideal behavior (I never want to include non-current stuff) but, I think overall I'd agree that select all should do what it says on the tin and select all. It'd definitely be worth thinking about some sort of "select real entries" though too in the future!

[youngcw]

I don't have any issue with parents of splits being included in the select all, as long as the selected total is calculated right.

For the schedules, I don't think those should be considered transactions since they have yet to be added. They are in the table for reference purposes. Also, the bulk options are different for schedules than for regular transactions.

[joel-jeremy]

I would then to agree that the parent should not be selected specially with the recent change where the parent transaction is just going to be a shell of its children transactions (no payee, no category)