actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
12.58k stars 960 forks source link

Revert scheduled transaction date filter causing weekly scheduled transactions as Paid #2890

Closed joel-jeremy closed 2 weeks ago

joel-jeremy commented 2 weeks ago

Fixes https://github.com/actualbudget/actual/issues/2851

netlify[bot] commented 2 weeks ago

Deploy Preview for actualbudget ready!

Name Link
Latest commit 344fcfb196e50685afdc8df28342b90cb5db0ba2
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/666f53b68ebe270008d64bd4
Deploy Preview https://deploy-preview-2890.demo.actualbudget.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 2 weeks ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.74 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/resize-observer.js | 18.37 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/usePreviewTransactions.js | 790 B | 0% static/js/AppliedFilters.js | 20.25 kB | 0% static/js/narrow.js | 75.73 kB | 0% static/js/wide.js | 263.43 kB | 0% static/js/ReportRouter.js | 1.23 MB | 0% static/js/index.js | 3.01 MB | 0%
github-actions[bot] commented 2 weeks ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.13 MB | 0%
Teprifer commented 2 weeks ago

A check with importing my budget shows this as working as intended with the weekly ones returning to Upcoming.

@MatissJanis I've received a request for approval, however can you review and approve this? While it appears simple I'd rather take a blanket approach of not approving any code change myself rather than risk an 'overabundance of confidence' type situation. :)