Timeout SimpleFIN sync calls after 60 seconds

psybers commented 3 months ago

Currently, if something goes wrong with the bank sync, the client essentially just 'hangs' while trying to sync and shows the account(s) as trying to sync forever. They do not seem to time out.

This places a 60-second limit on the call, and if it times out it then proceeds to indicate the link might be broken and users should relink the account.

netlify[bot] commented 3 months ago

Deploy Preview for actualbudget ready!

Name	Link
Latest commit	0273a157da4d3bdeae51b87e8519aad0f1be73f2
Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6671e3610f968500088bee65
Deploy Preview	https://deploy-preview-2891.demo.actualbudget.org
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 months ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.75 MB → 4.75 MB (+573 B)	+0.01%

Changeset

File | Δ | Size ---- | - | ---- `src/components/accounts/AccountSyncCheck.jsx` | 📈 +283 B (+6.29%) | 4.4 kB → 4.67 kB `src/components/modals/CreateAccountModal.tsx` | 📈 +290 B (+2.21%) | 12.8 kB → 13.09 kB

View detailed bundle breakdown

**Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.02 MB → 3.02 MB (+573 B) | +0.02% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/usePreviewTransactions.js | 790 B | 0% static/js/AppliedFilters.js | 20.25 kB | 0% static/js/narrow.js | 75.73 kB | 0% static/js/wide.js | 263.59 kB | 0% static/js/ReportRouter.js | 1.23 MB | 0%

github-actions[bot] commented 3 months ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.13 MB → 1.13 MB (+194 B)	+0.02%

Changeset

File | Δ | Size ---- | - | ---- `packages/loot-core/src/server/post.ts` | 📈 +249 B (+10.77%) | 2.26 kB → 2.5 kB `packages/loot-core/src/server/main.ts` | 📈 +154 B (+0.25%) | 60.12 kB → 60.27 kB `packages/loot-core/src/server/accounts/sync.ts` | 📈 +7 B (+0.03%) | 22.29 kB → 22.3 kB

View detailed bundle breakdown

**Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.13 MB → 1.13 MB (+194 B) | +0.02% **Smaller** No assets were smaller **Unchanged** No assets were unchanged

psybers commented 3 months ago

actualbudget / actual