Closed twk3 closed 3 months ago
Name | Link |
---|---|
Latest commit | b1989f291c3200683ffc11293f1b915f4a1c3359 |
Latest deploy log | https://app.netlify.com/sites/actualbudget/deploys/66713978bb98a40007d203f3 |
Deploy Preview | https://deploy-preview-2895.demo.actualbudget.org |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
Files count | Total bundle size | % Changed |
---|---|---|
9 | 4.75 MB | 0% |
Changeset
No files were changed
Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.
As this PR is updated, I'll keep you updated on how the bundle size is impacted.
Total
Files count | Total bundle size | % Changed |
---|---|---|
1 | 1.13 MB | 0% |
Changeset
No files were changed
@twk3 This might need some tweaks. #2554 was passing all checks prior to merging this PR in. It's failing now.
@carkom if you push another commit, it SHOULD pass. Or just go ahead and ignore it and merge as-is.
You will note there is a passing AND a failing version of the job in your checks. The failed one is a side effect (or maybe bug) of githubs pull_request_target. The passing one is from the actualbudget repo. The failing one was triggered by the introduction of the workflow to your branch. (via the merge of master).
It's a bit of a pain you run into anytime you change a pull_request_target action, and folks merge the change to their forks. But for most new PRs going forward (which will already have the workflow in their branch), it shouldn't trigger this way I hope.
Embed the trafico action as a workflow to get it working again.
(We can further improve or replace it going forward)
Here is an example showing it working for basic use case between two of my actual forks: (showing that forked workflow still works here) https://github.com/twk3/actual-actions-target/pull/14