actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
13.96k stars 1.11k forks source link

Trafico embedded action #2895

Closed twk3 closed 3 months ago

twk3 commented 3 months ago

Embed the trafico action as a workflow to get it working again.

(We can further improve or replace it going forward)

Here is an example showing it working for basic use case between two of my actual forks: (showing that forked workflow still works here) https://github.com/twk3/actual-actions-target/pull/14

netlify[bot] commented 3 months ago

Deploy Preview for actualbudget ready!

Name Link
Latest commit b1989f291c3200683ffc11293f1b915f4a1c3359
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66713978bb98a40007d203f3
Deploy Preview https://deploy-preview-2895.demo.actualbudget.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 months ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.75 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/usePreviewTransactions.js | 790 B | 0% static/js/AppliedFilters.js | 20.25 kB | 0% static/js/narrow.js | 75.73 kB | 0% static/js/wide.js | 263.59 kB | 0% static/js/ReportRouter.js | 1.23 MB | 0% static/js/index.js | 3.01 MB | 0%
github-actions[bot] commented 3 months ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.13 MB | 0%
carkom commented 3 months ago

@twk3 This might need some tweaks. #2554 was passing all checks prior to merging this PR in. It's failing now.

twk3 commented 3 months ago

@carkom if you push another commit, it SHOULD pass. Or just go ahead and ignore it and merge as-is.

You will note there is a passing AND a failing version of the job in your checks. The failed one is a side effect (or maybe bug) of githubs pull_request_target. The passing one is from the actualbudget repo. The failing one was triggered by the introduction of the workflow to your branch. (via the merge of master).

It's a bit of a pain you run into anytime you change a pull_request_target action, and folks merge the change to their forks. But for most new PRs going forward (which will already have the workflow in their branch), it shouldn't trigger this way I hope.