actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
12.51k stars 954 forks source link

:electron: Fix "Export" function on desktop app #2925

Closed MikesGlitch closed 1 week ago

MikesGlitch commented 1 week ago

partial for: https://github.com/actualbudget/actual/issues/2907

The issue is due to this bug https://github.com/electron/electron/issues/42621

We're working around it by using the async version of the same function (which works)

Tested:

netlify[bot] commented 1 week ago

Deploy Preview for actualbudget ready!

Name Link
Latest commit 3ca32a6afa0137859fdc0d4f20384a7db18791e9
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66786873f68d6c0008e121c2
Deploy Preview https://deploy-preview-2925.demo.actualbudget.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 week ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.76 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/resize-observer.js | 18.37 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/narrow.js | 75.73 kB | 0% static/js/usePreviewTransactions.js | 790 B | 0% static/js/AppliedFilters.js | 27.22 kB | 0% static/js/wide.js | 266.96 kB | 0% static/js/ReportRouter.js | 1.23 MB | 0% static/js/index.js | 3.02 MB | 0%
github-actions[bot] commented 1 week ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.13 MB | 0%
youngcw commented 1 week ago

Working for me. @MatissJanis Can you try the mac build?

MatissJanis commented 1 week ago

Mac still broken with this error when exporting.

But we can definitely merge this PR so Linux and Win would be fixed. Just don't close the linked issue.