Update DynamicBudgetTable to fill more of the view when viewing fewer months

jarneson33 commented 1 week ago

Hello, new to actual and loving the project! That said I was taken aback by the budgets view when only viewing 1-2 months on a high resolution panel. So I am opening this pull request to see if this is something the maintainers would be open to or if this fixed width is a mandatory design choice.

EDIT: Changed from allowing 100% span to just upping the original logic to allow the table to maintain original design but be less floaty island.

Thank you.

Before

After

netlify[bot] commented 1 week ago

Deploy Preview for actualbudget ready!

Name	Link
Latest commit	f2ba0b1cd991f2e5bce3c549b915d7e8163fdf09
Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/667ae16e17bae900070cd565
Deploy Preview	https://deploy-preview-2933.demo.actualbudget.org
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 week ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.76 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/narrow.js | 75.73 kB | 0% static/js/usePreviewTransactions.js | 790 B | 0% static/js/AppliedFilters.js | 27.22 kB | 0% static/js/wide.js | 266.96 kB | 0% static/js/ReportRouter.js | 1.23 MB | 0% static/js/index.js | 3.02 MB | 0%

github-actions[bot] commented 1 week ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.13 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.13 MB | 0%

Crazypkr1099 commented 1 week ago

Not a fan of this. Having it stretch across looks extremely weird. I'd be open to 50% instead of 100% 🤷

Teprifer commented 1 week ago

While there may be scope to allow the table to be a bit wider, the current images shown are too extreme. The data is divorced from the categories in single month and even two month views as the eye has to travserse too far from one side to the other.

Maybe put up a few set with different percentages for people to review and give feedback?

jarneson33 commented 1 week ago

@Crazypkr1099 @Teprifer yep I hear you guys, I agree too extreme in the other direction. I have pushed a changed to just allow the table to be a bit larger instead of doing any percentages. The table maintains original design but fills the space nicer. My main use case is doing two months side by side and this change allows two months to nicely fill the space and for the table to not look distorted from doing a full span when looking at 1-2 months.

Please review updated screenshots or the PR branch demo and let me know your thoughts.

Thank you.

Teprifer commented 4 days ago

Seems reasonable, keen to hear other's thoughts.

actualbudget / actual