actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
12.51k stars 954 forks source link

change the mobile budget balance colors to be the same as desktop #2940

Closed youngcw closed 6 days ago

youngcw commented 1 week ago

fix: #2938

The makes it so the mobile category balance acts the same on mobile as it does on desktop. Templates will cause colors for balance, otherwise only white, gray, or red.

This also fixes a small bug where the carryover arrow would always show the template color even with templates disabled.

netlify[bot] commented 1 week ago

Deploy Preview for actualbudget ready!

Name Link
Latest commit 6a2e0ac08736b11fb22bdd50b9a88a4d17e82684
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/667b285510b2de0008853141
Deploy Preview https://deploy-preview-2940.demo.actualbudget.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 week ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.76 MB → 4.76 MB (+270 B) +0.01%
Changeset File | Δ | Size ---- | - | ---- `src/components/budget/BalanceWithCarryover.tsx` | 📈 +32 B (+2.08%) | 1.5 kB → 1.53 kB `src/components/mobile/budget/BudgetTable.jsx` | 📈 +238 B (+0.48%) | 48.8 kB → 49.03 kB
View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/narrow.js | 75.73 kB → 75.96 kB (+238 B) | +0.31% static/js/index.js | 3.02 MB → 3.02 MB (+32 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/usePreviewTransactions.js | 790 B | 0% static/js/AppliedFilters.js | 27.22 kB | 0% static/js/wide.js | 266.96 kB | 0% static/js/ReportRouter.js | 1.23 MB | 0%
github-actions[bot] commented 1 week ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.13 MB | 0%
youngcw commented 1 week ago

@matt-fidd I think this fixes that issue. Can you check?

matt-fidd commented 1 week ago

Wow, that was fast, thank you! Can confirm it fixes the bug.