actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
12.51k stars 954 forks source link

Remove the trafico pr review triggers #2942

Open twk3 opened 6 days ago

twk3 commented 6 days ago

These triggers were causing errors on forks, due to lack of permissions on these actions

This at least stops the errors. As far as I can tell, we will need a hosted bot if we want to enable triggering on review changes.

netlify[bot] commented 6 days ago

Deploy Preview for actualbudget ready!

Name Link
Latest commit 226c505d8dbb9e64828eec9786b32546a0a6ebfa
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/667c2a2506379000083f37bf
Deploy Preview https://deploy-preview-2942.demo.actualbudget.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 6 days ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.76 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/usePreviewTransactions.js | 790 B | 0% static/js/AppliedFilters.js | 27.22 kB | 0% static/js/narrow.js | 75.73 kB | 0% static/js/wide.js | 266.96 kB | 0% static/js/ReportRouter.js | 1.23 MB | 0% static/js/index.js | 3.02 MB | 0%
github-actions[bot] commented 6 days ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.13 MB | 0%
matt-fidd commented 6 days ago

Hi @twk3. Would you still be open to me creating a typescript based hosted bot for actual? If so can I open an issue to discuss the approach and to get some feedback?

MatissJanis commented 6 days ago

Looks like removing these actions doesn't update the label from "Ready for review" -> "Approved" 😢