search

actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
12.51k stars 954 forks source link

Port finance modals to use new Modal component based on React Aria Modal #2946

Open joel-jeremy opened 6 days ago

joel-jeremy commented 6 days ago

No changes were made on the Modal children nodes aside from adding a <ModalHeader ... /> component and making the children node a lambda which accepts a close function

netlify[bot] commented 6 days ago

Deploy Preview for actualbudget ready!

Name Link
Latest commit ef1b7dbe9c876c6e7f1f2f970be7c6360f86ea14
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/667f44362960c4000842c197
Deploy Preview https://deploy-preview-2946.demo.actualbudget.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 6 days ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.77 MB → 4.82 MB (+49.24 kB) +1.01%
Changeset File | Δ | Size ---- | - | ---- `src/components/common/Modal2.tsx` | 🆕 +9.04 kB | 0 B → 9.04 kB `node_modules/@react-aria/dialog/dist/import.mjs` | 🆕 +3.63 kB | 0 B → 3.63 kB `src/hooks/useModalState.ts` | 🆕 +657 B | 0 B → 657 B `src/components/modals/RolloverToBudgetMenuModal.tsx` | 📈 +345 B (+56.93%) | 606 B → 951 B `node_modules/react-aria-components/dist/import.mjs` | 📈 +10.52 kB (+53.07%) | 19.83 kB → 30.36 kB `src/components/modals/ManageRulesModal.tsx` | 📈 +353 B (+50.65%) | 697 B → 1.03 kB `src/components/modals/ReportBudgetSummaryModal.tsx` | 📈 +465 B (+40.83%) | 1.11 kB → 1.57 kB `src/components/modals/ConfirmUnlinkAccount.tsx` | 📈 +514 B (+33.93%) | 1.48 kB → 1.98 kB `src/components/modals/ConfirmTransactionDelete.tsx` | 📈 +456 B (+33.65%) | 1.32 kB → 1.77 kB `src/components/modals/BudgetListModal.tsx` | 📈 +316 B (+28.16%) | 1.1 kB → 1.4 kB `src/components/modals/NotesModal.tsx` | 📈 +473 B (+25.13%) | 1.84 kB → 2.3 kB `src/components/modals/SingleInputModal.tsx` | 📈 +458 B (+24.48%) | 1.83 kB → 2.27 kB `src/components/modals/RolloverBudgetSummaryModal.tsx` | 📈 +529 B (+22.66%) | 2.28 kB → 2.8 kB `src/components/modals/HoldBufferModal.tsx` | 📈 +382 B (+21.41%) | 1.74 kB → 2.12 kB `src/components/modals/ReportBalanceMenuModal.tsx` | 📈 +364 B (+20.74%) | 1.71 kB → 2.07 kB `src/components/modals/RolloverBalanceMenuModal.tsx` | 📈 +370 B (+20.32%) | 1.78 kB → 2.14 kB `src/components/modals/SimpleFinInitialise.tsx` | 📈 +486 B (+19.98%) | 2.38 kB → 2.85 kB `src/components/modals/ConfirmTransactionEdit.tsx` | 📈 +560 B (+19.93%) | 2.74 kB → 3.29 kB `src/components/schedules/ScheduleLink.tsx` | 📈 +562 B (+19.58%) | 2.8 kB → 3.35 kB `src/components/schedules/PostsOfflineNotification.jsx` | 📈 +523 B (+17.37%) | 2.94 kB → 3.45 kB `src/components/modals/BudgetPageMenuModal.tsx` | 📈 +330 B (+16.70%) | 1.93 kB → 2.25 kB `src/components/modals/TransferModal.tsx` | 📈 +538 B (+16.36%) | 3.21 kB → 3.74 kB `src/components/modals/GoCardlessInitialise.tsx` | 📈 +524 B (+15.77%) | 3.25 kB → 3.76 kB `src/components/modals/AccountAutocompleteModal.tsx` | 📈 +275 B (+15.59%) | 1.72 kB → 1.99 kB `src/components/modals/ConfirmCategoryDelete.tsx` | 📈 +648 B (+15.57%) | 4.07 kB → 4.7 kB `src/components/modals/ScheduledTransactionMenuModal.tsx` | 📈 +355 B (+15.47%) | 2.24 kB → 2.59 kB `src/components/modals/RolloverBudgetMenuModal.tsx` | 📈 +354 B (+15.26%) | 2.27 kB → 2.61 kB `src/components/modals/ReportBudgetMenuModal.tsx` | 📈 +352 B (+15.19%) | 2.26 kB → 2.61 kB `src/components/modals/CreateLocalAccountModal.tsx` | 📈 +929 B (+15.18%) | 5.97 kB → 6.88 kB `src/components/modals/PayeeAutocompleteModal.tsx` | 📈 +231 B (+15.13%) | 1.49 kB → 1.72 kB `src/components/modals/LoadBackup.jsx` | 📈 +699 B (+14.85%) | 4.6 kB → 5.28 kB `src/components/modals/CategoryAutocompleteModal.tsx` | 📈 +292 B (+14.73%) | 1.94 kB → 2.22 kB `src/components/modals/CoverModal.tsx` | 📈 +342 B (+13.96%) | 2.39 kB → 2.73 kB `src/components/modals/ReportBudgetMonthMenuModal.tsx` | 📈 +654 B (+12.88%) | 4.96 kB → 5.6 kB `src/components/modals/RolloverBudgetMonthMenuModal.tsx` | 📈 +670 B (+12.85%) | 5.09 kB → 5.75 kB `src/components/modals/SwitchBudgetTypeModal.tsx` | 📈 +231 B (+11.76%) | 1.92 kB → 2.14 kB `src/components/modals/CloseAccountModal.tsx` | 📈 +995 B (+11.71%) | 8.3 kB → 9.27 kB `src/components/modals/AccountMenuModal.tsx` | 📈 +474 B (+9.72%) | 4.76 kB → 5.22 kB `src/components/modals/CreateAccountModal.tsx` | 📈 +1.25 kB (+9.53%) | 13.09 kB → 14.33 kB `src/components/modals/FixEncryptionKeyModal.tsx` | 📈 +493 B (+9.24%) | 5.21 kB → 5.69 kB `src/components/modals/CategoryMenuModal.tsx` | 📈 +451 B (+9.00%) | 4.89 kB → 5.33 kB `src/components/modals/CategoryGroupMenuModal.tsx` | 📈 +520 B (+8.99%) | 5.65 kB → 6.15 kB `src/components/modals/CreateEncryptionKeyModal.tsx` | 📈 +610 B (+7.75%) | 7.69 kB → 8.29 kB `src/components/schedules/DiscoverSchedules.tsx` | 📈 +443 B (+6.95%) | 6.22 kB → 6.65 kB `src/components/modals/GoCardlessExternalMsg.tsx` | 📈 +538 B (+6.23%) | 8.43 kB → 8.96 kB `src/components/modals/EditField.jsx` | 📈 +447 B (+6.12%) | 7.13 kB → 7.57 kB `src/components/mobile/budget/index.tsx` | 📈 +602 B (+6.10%) | 9.63 kB → 10.22 kB `src/components/modals/SelectLinkedAccounts.jsx` | 📈 +327 B (+4.67%) | 6.84 kB → 7.16 kB `src/components/schedules/ScheduleDetails.jsx` | 📈 +1.21 kB (+4.38%) | 27.64 kB → 28.85 kB `src/components/modals/EditRule.jsx` | 📈 +1.37 kB (+3.99%) | 34.46 kB → 35.83 kB `src/components/modals/ImportTransactions.jsx` | 📈 +1012 B (+2.57%) | 38.47 kB → 39.46 kB `src/components/mobile/budget/BudgetTable.jsx` | 📈 +1.22 kB (+2.49%) | 49.03 kB → 50.25 kB `node_modules/@react-aria/overlays/dist/import.mjs` | 📈 +1.13 kB (+1.69%) | 66.95 kB → 68.08 kB `src/components/modals/MergeUnusedPayees.jsx` | 📈 +45 B (+0.70%) | 6.25 kB → 6.3 kB `src/components/manager/ImportYNAB4.tsx` | 📈 +2 B (+0.07%) | 2.97 kB → 2.97 kB `src/components/manager/ImportYNAB5.tsx` | 📈 +2 B (+0.07%) | 2.99 kB → 2.99 kB `src/components/manager/ImportActual.tsx` | 📈 +2 B (+0.06%) | 3.36 kB → 3.37 kB `src/components/manager/Import.tsx` | 📈 +2 B (+0.06%) | 3.38 kB → 3.38 kB `src/components/manager/DeleteFile.tsx` | 📈 +2 B (+0.05%) | 4.13 kB → 4.14 kB `src/components/FatalError.tsx` | 📈 +2 B (+0.03%) | 6.8 kB → 6.8 kB `src/components/common/Modal.tsx` | 📉 -715 B (-7.27%) | 9.61 kB → 8.91 kB `src/components/Modals.tsx` | 📉 -1.12 kB (-7.38%) | 15.14 kB → 14.03 kB
View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.02 MB → 3.07 MB (+47.44 kB) | +1.53% static/js/narrow.js | 75.96 kB → 77.77 kB (+1.81 kB) | +2.38% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/resize-observer.js | 18.37 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/usePreviewTransactions.js | 790 B | 0% static/js/AppliedFilters.js | 27.22 kB | 0% static/js/wide.js | 272.68 kB | 0% static/js/ReportRouter.js | 1.23 MB | 0%
github-actions[bot] commented 6 days ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.13 MB | 0%