search

actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
15.62k stars 1.21k forks source link

Update splash background to match theming #3400

Closed jfdoming closed 2 months ago

jfdoming commented 2 months ago

I noticed that (at least on Android) the PWA looks weird when launching: the background is fully white, which makes it look like we didn't bother to theme the app. This PR updates the background color to match the theme, which I think is reasonable (e.g., my bank's app has a splash-screen background color that matches the icon). I think we could still do better (e.g., having a higher-resolution image—the current icon looks a little blurry in the screenshot below) but IMO this is an improvement.

Thoughts? If this is something we want to add, having someone test on iOS would be great (I don't have a device handy).

Recommend reviewing with whitespace diff off (my editor auto-formatted 😞).

Before After
image image
netlify[bot] commented 2 months ago

Deploy Preview for actualbudget ready!

Name Link
Latest commit 42c40c776d2dd48c9cb53fd7474fc3e956050e62
Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66de199453986800080e446b
Deploy Preview https://deploy-preview-3400.demo.actualbudget.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 2 months ago

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 5.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 13.5 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 122.29 kB | 0% static/js/usePreviewTransactions.js | 1.59 kB | 0% static/js/AppliedFilters.js | 21.01 kB | 0% static/js/narrow.js | 78.68 kB | 0% static/js/wide.js | 224.58 kB | 0% static/js/ReportRouter.js | 1.49 MB | 0% static/js/index.js | 3.26 MB | 0%
github-actions[bot] commented 2 months ago

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.19 MB 0%

Changeset

No files were changed

View detailed bundle breakdown
**Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.js | 1.19 MB | 0%