actualbudget / actual

A local-first personal finance app
https://actualbudget.org
MIT License
13.81k stars 1.1k forks source link

[Bug]: Setting end month before starting month shows 7 months of data which seems odd #3421

Open Teprifer opened 1 week ago

Teprifer commented 1 week ago

Verified issue does not already exist?

What happened?

Assuming a budget file with enough data in it to go back.

Steps to reproduce:

  1. View net worth or cash flow graph
  2. Change time period to the preset 6 months option
  3. Result: 6 months show across the X axis (Image 1)
  4. Change the end month to a month at least 6 month ago (i.e. March 2024 or older)
  5. Result, x axis displays 7 months

Image 1: image

Image 2: image

Same occurs if using the other pre-set periods as it'll set to 7 months worth any time the end month is set to before the starting month and it's auto-adjusting to give a sane result.

Kinda minor I guess since when changing the end month you'd probably expect the starting month to also be changed, but it did look odd as not matching any of the pre-set options and stands out more as being incorrect if you'd started from the 6 month option.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox, Chrome

Operating System

Windows 11

youngcw commented 2 days ago

Maybe the fixed start month should get changed to be the same month since one month of view is the default now.

Teprifer commented 1 day ago

Maybe the fixed start month should get changed to be the same month since one month of view is the default now.

That makes sense too, I think either or would be fine.