new CLI feature: maintain battery in a certain range

actuallymentor / battery

CLI/GUI for managing the battery charging status for Apple silicon (M1, M32, M3) Macs

MIT License

3.58k stars 148 forks source link

new CLI feature: maintain battery in a certain range #261

Open seefood opened 5 months ago

seefood commented 5 months ago

https://github.com/actuallymentor/battery: Fix bug Add files via upload cleared up logging message cleared up logging message added integer check for charge command argument

Actually #227 by @tangb4c with some code improvements and inline comments

actuallymentor commented 3 months ago

Thanks for the addition Seefood!

If I read this correctly, the while loop has no throttling so would be running in very rapid succession. Was that a design decision?

seefood commented 3 months ago

There's a 1 minute sleep there at the end of the while loop, so battery levels are sampled once a minute. Do you feel it should be more like 5 minutes?

enricodelarosa commented 4 days ago

Hi,

Just wanted to ask if PR is just waiting for the loop throttle/sleep fix or resolution?