search

actum / gulp-dev-stack

Actum dev stack based on gulp
MIT License
11 stars 7 forks source link

Layout: main class #108

Closed kettanaito closed 7 years ago

kettanaito commented 7 years ago

The current usage:

<main role="main" class="container">

Remove "container" class

I would not recommend using bootstrap's container class on the root node of page content. Suggesting to nest it inside the <main> tag:

<main role="main">
    <div class="container">
    </div>
</main>

Remove role="main"

There is a great tool for HTML5 proper markup validation. When uploaded our index.html we get a following error:

Warning: Element `main` does not need a `role` attribute.

I think this is because there can be only one <main> tag in the whole document. ARIA specification attributes were provided before roles were natively supported by HTML5.

Usage of HTML5 markup should be supported, since it is not even a new feature as for 2016.

kettanaito commented 7 years ago

It should be also discussed whether we really need to nest div class="container"> inside <main>.

What about instances when nested content has fluid container? Maybe it is better to define container in each block macro extension?

janpanschab commented 7 years ago

This depends on project. IMHO this is quite easy task and we don’t need to show best practice here.

kettanaito commented 7 years ago

@janpanschab then I will create a pull request with the changes I currently have.