search

actum / gulp-dev-stack

Actum dev stack based on gulp
MIT License
11 stars 7 forks source link

remove old gulp task: gulp-uglify #167

Closed Lin84 closed 7 years ago

Lin84 commented 7 years ago

in the gulp task for JS we have 2 plugins that do the same thing = Minify JavaScript with UglifyJS2. 'gulp-uglify' and 'uglifyify'

We should use only one of them. As @janpanschab recommended: using only 'uglifyify' and remove 'gulp-uglify'.

ronaldruzicka commented 7 years ago

I just tested the missing uglify task in Walmark project, and there was a significant difference between the file size. with: 237KB without: 731KB

So I think that we should put it back to dev stack.

vbulant commented 7 years ago

@ronaldruzicka Yes, we should. A bit of reasoning: https://github.com/actum/gulp-dev-stack/pull/168#issuecomment-300084283