search

acuminous / yadda

A BDD javascript library
412 stars 73 forks source link

False positives with `mocha.StepLevelPlugin` #183

Closed MoonByteShaker closed 8 years ago

MoonByteShaker commented 8 years ago

Hi, if i'm using version 0.14.0 and i get the same bug as mentioned in issue #120. If the first tests fails the following tests are completed even i there have to fail.

Greetings Max

cressie176 commented 8 years ago

Can you try with the latest version of mocha?

MoonByteShaker commented 8 years ago

Thanks, it worked :-) Unfortunately it only worked in one package. Another package which is based on the yadda protractor example has still the same bug even if i update moch or jasmine.

cressie176 commented 8 years ago

It's a while since I looked at this but I suspect jasmine doesn't provide the option to programmatically skip tests. This was only added relatively recently in mocha which is why you needed to upgrade for your other package.

cressie176 commented 8 years ago

Any luck?

MoonByteShaker commented 8 years ago

Hi, sorry for the late response... family, moving to another country stuff... Unfortunately i had no luck.

Actually... the behavior changed a little bit: The test results are always true... One example:

When I search for max
then the title is foo - Recherche Google

The test result of this must be wrong, since the title should be max - Recherche Google and not foo - Recherche Google. I picked this from your yadda - protractor example.

Greetings Max

cressie176 commented 8 years ago

I got the same. The protractor example was a contribution - I ran it and it passed. I never thought to check whether it would fail though. I've remove it as webdriverjs is deprecated and I'm not familiar with protractor.

MoonByteShaker commented 8 years ago

Thanks for your quick response. Maybe i will try to fix this on my own. But other things are waiting too ^^