Open farishkash opened 6 years ago
Thanks for the suggestion! I agree with your opinion and will definitely check out that style guide.
Would like to get a job as a web developer/designer with some freelance work, so this will definitely be useful!
Overall met expectations.
The project is working properly.
Great job getting this up and running. I am sure you worked hard on this.
There were no errors for me to deconstruct which made this a really easy review.
I believe that you and I have interacted a few times to go over some of your javascript/react issues in the advisor chat.
My only concern which I don't believe is worthy of an issue is code formatting.
I don't know what your overall goals. If you are planning on showcasing your code for freelancing, subcontracting, or job hunting, I believe that presentation matters.
As a general rule, I follow the Airbnb style guide.
https://github.com/airbnb/javascript/tree/master/react
This is opinionated, so if it isn't part of your goals or you don't feel it isn't necessary that is ok too.
A couple examples from your app.js that I reformatted for you to reference.
Your state in the constructor.
As a general rule whenever you have an opening bracket, you want to drop the code onto the next line.
Reformatted below.
Your render section.
Each prop of a multi-prop jsx component drops to the next line . Reformatted below.
Good luck on your endeavors.