search

acvetkov / sinon-chrome

Testing chrome extensions with Node.js
ISC License
435 stars 46 forks source link

Include bundled browser file for npm distribution #28

Closed thgaskell closed 8 years ago

thgaskell commented 8 years ago

After looking at #24:

I have excluded sinon-chrome bundle from git index last month, because it mess up git diffs.

I agree that the bundle should be in the .gitignore file, but why is it in .npmignore? The prepublish script looks like it's compiling the bundled file, but it's ignored from the npm release.

It would be nice to include the bundled file in npm so that it could be used by projects that use sinon-chrome as a dependency for browser tests. Currently you have to go into node_modules/sinon-chrome folder and manually build the bundle with webpack.

vitalets commented 8 years ago

:+1:

acvetkov commented 8 years ago

:+1:

acvetkov commented 8 years ago

@thgaskell hi!

I've released 1.1.2 version, that includes your changes. I've published new version in npm. Check it out.

thgaskell commented 8 years ago

Looks great, thank you! :+1: