Introduce I18nPlugin

[SokratisVidros]

Hi there,

I've implemented a mock I18nPlugin in order to test Chrome extensions that rely heavily on i18n for their copywriting. As shown in the following snippet, the plugin can be used with the original translation file.

import translations from '../app/_locales/en/messages.json';
chrome = require('sinon-chrome');
chrome.registerPlugin(new global.chrome.plugins.I18nPlugin(translations));

Thanks in advance.

[coveralls]

Coverage increased (+0.4%) to 93.814% when pulling 32ca13fc0aa19b7ec6c9d3adb6754677c72e1c09 on SokratisVidros:master into 993fe1412d5100ff2e92f72de2322f7c7e8efe80 on acvetkov:master.

[acvetkov]

@SokratisVidros hi! thank you for great work!

Can you append jsdoc (@param, @returns and description) to all public methods?

[SokratisVidros]

Sure.

Regards,

---

Sokratis Vidros Senior Software Engineer @ Workable http://workable.com/

2016-08-24 12:44 GMT+03:00 Aleksey Tsvetkov notifications@github.com:

@SokratisVidros https://github.com/SokratisVidros hi! thank you for great work!

Can you append jsdoc (@param, @returns and description) to all public methods?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/acvetkov/sinon-chrome/pull/36#issuecomment-242010789, or mute the thread https://github.com/notifications/unsubscribe-auth/ABSi5pYQ0K2zQvW-GLcSIa-SoFeK8Zs9ks5qjBKPgaJpZM4JrzCv .

[SokratisVidros]

JSDOC annotations added!

[coveralls]

Coverage increased (+0.4%) to 93.814% when pulling 3438a4c572d67ef108984d9b2bdfb2b9e4ec5c69 on SokratisVidros:master into 993fe1412d5100ff2e92f72de2322f7c7e8efe80 on acvetkov:master.

[acvetkov]

👍

[SokratisVidros]

Thanks :)

[acvetkov]

check out new version with your pr https://www.npmjs.com/package/sinon-chrome

[SokratisVidros]

Great! Already in my projects' package.json :)

Regards,

---

Sokratis Vidros Senior Software Engineer @ Workable http://workable.com/

2016-08-24 13:41 GMT+03:00 Aleksey Tsvetkov notifications@github.com:

check out new version with your pr https://www.npmjs.com/package/sinon-chrome

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/acvetkov/sinon-chrome/pull/36#issuecomment-242023174, or mute the thread https://github.com/notifications/unsubscribe-auth/ABSi5rUPhVz-JugKvFnNgB5kp82U8WfIks5qjB_hgaJpZM4JrzCv .

[vitalets]

👍 great!