search

acvetkov / sinon-chrome

Testing chrome extensions with Node.js
ISC License
435 stars 46 forks source link

chai-as-promised is only used in tests, so it can be a devDependency. #47

Closed Standard8 closed 7 years ago

Standard8 commented 7 years ago

When I install the latest version of sinon-chrome (2.1.0), then I get:

- lodash@3.10.1 node_modules/sinon-chrome/node_modules/lodash
examplewebextension@0.0.1 /Users/mark/dev/example-webextension
└─┬ sinon-chrome@2.1.0 
  ├── UNMET PEER DEPENDENCY chai@>= 2.1.2 < 4
  └─┬ chai-as-promised@6.0.0 
    └── check-error@1.0.2 

npm WARN chai-as-promised@6.0.0 requires a peer of chai@>= 2.1.2 < 4 but none was installed.

chai-as-promised has a peer dependency of chai but chai isn't listed in the dependencies for sinon-chrome. However chai-as-promised appears to only be used for tests and not for the main library, so I think we can just move it to the devDependencies and installations should then be happy.

acvetkov commented 7 years ago

@Standard8, hi. my mistake.